Skip to content

Update nw-installing-external-dns-operator-cli.adoc #96013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update nw-installing-external-dns-operator-cli.adoc #96013

wants to merge 1 commit into from
+5 −5

Conversation

prithvipatil97
Copy link
Contributor

@prithvipatil97 prithvipatil97 commented Jul 11, 2025 •
edited
Loading

Here is the current look of the verification section of the documentation: Verification

Get the name of the install plan from the subscription by running the following command:

$ oc -n external-dns-operator \
      get subscription external-dns-operator \
      --template='{{.status.installplan.name}}{{"\n"}}'

Verify that the status of the install plan is Complete by running the following command:

$ oc -n external-dns-operator \
      get ip <install_plan_name> \
      --template='{{.status.phase}}{{"\n"}}'
  • The above commands are not structured properly.
  • We can use the above command as well, and it will execute perfectly.
  • But its structure is not as per our standard procedure.
  • Hence, it needs to be changed.

Here is the updated look:

Verification

Get the name of the install plan from the subscription by running the following command:

$ oc -n external-dns-operator \
  get subscription external-dns-operator \
  --template='{{.status.installplan.name}}{{"\n"}}'

Verify that the status of the install plan is Complete by running the following command:

$ oc -n external-dns-operator \
  get ip <install_plan_name> \
  --template='{{.status.phase}}{{"\n"}}

Version(s):

RHOCP 4.20, RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16 , RHOCP 4.15

Issue:

https://issues.redhat.com/browse/OSDOCS-15279

Link to docs preview:

https://96013--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/external_dns_operator/nw-installing-external-dns-operator-on-cloud-providers.html

QE review:

  • QE has approved this change.

Additional information:

@prithvipatil97
Update nw-installing-external-dns-operator-cli.adoc
447d5f4 
Here is the current look of the verification section of the documentation:
Verification

Get the name of the install plan from the subscription by running the following command:
$ oc -n external-dns-operator \
    get subscription external-dns-operator \
    --template='{{.status.installplan.name}}{{"\n"}}' 
Verify that the status of the install plan is Complete by running the following command:
$ oc -n external-dns-operator \
    get ip <install_plan_name> \
    --template='{{.status.phase}}{{"\n"}}' 
The above commands are not structured properly.
We can use the above command as well, and it will execute perfectly.
But its structure is not as per our standard procedure.
Hence, it needs to be changed.
Here is the updated look:

Verification

Get the name of the install plan from the subscription by running the following command:
$ oc -n external-dns-operator \
  get subscription external-dns-operator \
  --template='{{.status.installplan.name}}{{"\n"}}'
Verify that the status of the install plan is Complete by running the following command:
$ oc -n external-dns-operator \
  get ip <install_plan_name> \
  --template='{{.status.phase}}{{"\n"}}
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2025
@ocpdocs-previewbot
Copy link

🤖 Fri Jul 11 16:10:41 - Prow CI generated the docs preview:

https://96013--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/external_dns_operator/nw-installing-external-dns-operator-on-cloud-providers.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 11, 2025

@prithvipatil97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prithvipatil97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 11, 2025
@mburke5678 mburke5678 added this to the Continuous Release milestone Jul 11, 2025
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@prithvipatil97
Copy link
Contributor Author

Hello Team,
I need QE approval for this change.

All checks have passed, and Peer review is also done.

It would be really helpful if someone could please take a look and provide QE approval for this change.

cc: @zhaozhanqi, @yingwang-0320, @lihongan, @rhamini3

Regards,
Prithviraj Patil

@lihongan
Copy link

LGTM!
Thank you @prithvipatil97

@prithvipatil97
Copy link
Contributor Author

LGTM! Thank you @prithvipatil97

Hello Hongan,
Thanks for providing the QE approval for this change.

@prithvipatil97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mburke5678 mburke5678

Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. merge-review-needed Signifies that the merge review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@prithvipatil97 @ocpdocs-previewbot @mburke5678 @lihongan